ci(qt): cap Qt WebEngine leak gate with timeout-minutes: 20 - #170
Merged
Conversation
The leak harness wraps the run in `timeout 180`, but QtWebEngine spawns Chromium zygote/helper child processes that survive when timeout SIGTERMs only the immediate child. The orphans keep the xvfb-run pipe open, so the job hangs to the 360-min runner default instead of finishing. A job-level timeout-minutes makes the runner force-kill the whole process tree, so a hung gate costs ~20 min, not hours. continue-on-error semantics are unchanged (gate stays advisory during Qt bring-up).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
qt-webengineleak gate wraps its run intimeout 180, but that only SIGTERMs the immediate child. QtWebEngine spawns Chromium zygote/helper processes that survive, hold thexvfb-runpipe open, and hang the job to the 360-min runner default. Observed cost: ~35 min × 3 today; #165 had to be closed/reopened to clear a stuck run.Fix
Add a job-level
timeout-minutes: 20so the runner force-kills the whole process tree when the gate hangs. A healthy run (apt + Qt harness build + 180s harness) finishes well under 20 min; a hang now costs ~20 min instead of hours.Scope: one line (+ comment) in build.yml.
continue-on-erroris unchanged — the gate stays advisory during Qt bring-up.Merge-gated: holding for operator push-approval.